[Caja] Re: ES6 changed to exempt more primordials prototypes from being plain object. (issue 288270043 by [e-mail])

[kpreid via Google Caja Discuss]

LGTM


https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js#newcode1848
src/com/google/caja/ses/repairES5.js:1848: * As of ES6, for all the
builtin constructors except
You have "except
(except" in this comment. Also, maybe put "that make" before the list of
exceptions?

Same below.

https://codereview.appspot.com/288270043/

[r***@codereview-hr.appspotmail.com]

The code we're fixing dates from when ES6 exempted only Function and
Array from the requirement that their .prototype be a plain object
rather than an exotic instance of their constructor type. This was
found not to be web compatible, so ES6 now additionally exempts
Boolean, Number, and String. Importantly, Date, RegExp, and WeakMap
are not exempt.


revised comment


https://codereview.appspot.com/288270043/

[e***@gmail.com]

https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js#newcode1848
src/com/google/caja/ses/repairES5.js:1848: * As of ES6, for all the
builtin constructors except

Post by kpreid via Google Caja Discuss
You have "except
(except" in this comment. Also, maybe put "that make" before the list

of

Post by kpreid via Google Caja Discuss
exceptions?
Same below.

Done.

https://codereview.appspot.com/288270043/

[Mark Miller]

Well, my other change, which does not alter .next, got stuck the same
place, as did bug I filed seem to -- though I did not scroll that browser
window to the bottom at the time. My assumption that they are the same is
your comment "related to iterators IIRC".

I'm going to proceed and try to commit both.

Post by kpreid via Google Caja Discuss
https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js
https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js#newcode1848
src/com/google/caja/ses/repairES5.js:1848: * As of ES6, for all the
builtin constructors except

Post by kpreid via Google Caja Discuss
You have "except
(except" in this comment. Also, maybe put "that make" before the list

of

Post by kpreid via Google Caja Discuss
exceptions?

Same below.
Done.
https://codereview.appspot.com/288270043/

--
Cheers,
--MarkM

[Mark Miller]

Well that's strange. I just now did a "git push" which succeeded. I then
went to https://github.com/google/caja/commits/master and it showed the
commit, but said it happened 16 minutes ago. Less that one minute happened
between my push and looking at the github page.

Post by Mark Miller
Well, my other change, which does not alter .next, got stuck the same
place, as did bug I filed seem to -- though I did not scroll that browser
window to the bottom at the time. My assumption that they are the same is
your comment "related to iterators IIRC".
I'm going to proceed and try to commit both.

Post by kpreid via Google Caja Discuss
https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js
https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js#newcode1848
src/com/google/caja/ses/repairES5.js:1848: * As of ES6, for all the
builtin constructors except

Post by kpreid via Google Caja Discuss
You have "except
(except" in this comment. Also, maybe put "that make" before the list

of

Post by kpreid via Google Caja Discuss
exceptions?

Same below.
Done.
https://codereview.appspot.com/288270043/

--
Cheers,
--MarkM

--
Cheers,
--MarkM

[Mark Miller]

Nevermind. It is telling me the time that these changes were committed
anywhere, not when they were pushed to github, right?

Post by Mark Miller
Well that's strange. I just now did a "git push" which succeeded. I then
went to https://github.com/google/caja/commits/master and it showed the
commit, but said it happened 16 minutes ago. Less that one minute happened
between my push and looking at the github page.

Post by Mark Miller
Well, my other change, which does not alter .next, got stuck the same
place, as did bug I filed seem to -- though I did not scroll that browser
window to the bottom at the time. My assumption that they are the same is
your comment "related to iterators IIRC".
I'm going to proceed and try to commit both.

Post by kpreid via Google Caja Discuss
https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js
https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js#newcode1848
src/com/google/caja/ses/repairES5.js:1848: * As of ES6, for all the
builtin constructors except

Post by kpreid via Google Caja Discuss
You have "except
(except" in this comment. Also, maybe put "that make" before the list

of

Post by kpreid via Google Caja Discuss
exceptions?

Same below.
Done.
https://codereview.appspot.com/288270043/

--
Cheers,
--MarkM

--
Cheers,
--MarkM

--
Cheers,
--MarkM

['Kevin Reid' via Google Caja Discuss]

Post by Mark Miller
Nevermind. It is telling me the time that these changes were committed
anywhere, not when they were pushed to github, right?

Yes, exactly.

More than you wanted to know: There are two dates in git commit data, the
"author date" and the "committer date" (going along with two different
attributions). They are usually the same, but are different if a commit was
amended or e.g. mailed by the author as a patch and turned into a git
commit by someone else.

_Neither_ of these dates is the date of push: commits are not modified by
being pushed. So to be able to do what you were first expecting, GitHub
would have to be keeping a mapping of commit → push the commit was first
seen in → date thereof. And then is “first seen in” for the current branch,
or any branch (including deleted ones), or what?

Distributed systems are necessarily more complex, film at <error: true
ordering of events not definable>.